Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(desktop): improve clearing history messages #1173

Merged
merged 3 commits into from
Dec 21, 2022
Merged

improve(desktop): improve clearing history messages #1173

merged 3 commits into from
Dec 21, 2022

Conversation

Red-Asuka
Copy link
Member

@Red-Asuka Red-Asuka commented Dec 21, 2022 •
edited
Loading

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

  • Improve clearing history messages
  • Close the menu bar after clicking on the copy option
  • Modify the location of the read/write push prop method

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka added performance Improve some performance desktop MQTTX Desktop labels Dec 21, 2022
@Red-Asuka Red-Asuka requested a review from ysfscream December 21, 2022 07:26
@Red-Asuka Red-Asuka self-assigned this Dec 21, 2022
@ysfscream ysfscream merged commit 83216f6 into emqx:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysfscream ysfscream ysfscream approved these changes

Assignees

@Red-Asuka Red-Asuka

Labels
desktop MQTTX Desktop performance Improve some performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Red-Asuka @ysfscream