Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(about): update the emqx cloud description #1253

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

Please describe the new behavior or provide screenshots.

image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request docs Add or update documents desktop MQTTX Desktop labels Mar 31, 2023
@ysfscream ysfscream requested a review from Red-Asuka March 31, 2023 09:23
@ysfscream ysfscream self-assigned this Mar 31, 2023
en: 'Unlock the power of IoT with EMQX Cloud - the fully managed MQTT cloud service platform that connects massive amounts of devices and processes real-time data with flexible pay-per-use billing.',
tr: `EMQX Cloud ile IoT'un gücünü keşfedin - tamamen yönetilen MQTT bulut hizmet platformu, milyonlarca cihazı bağlar ve gerçek zamanlı verileri esnek kullanım ücreti ödeme ile işler.`,
ja: 'EMQX Cloudを使用してIoTの強力な機能を発見しましょう。EMQX Cloudは、大規模なデバイスを接続し、リアルタイムデータを柔軟な使用料金で処理することができる完全に管理されたMQTTクラウドサービスプラットフォームです。',
hu: 'Fedezze fel az IoT erőteljes lehetőségeit az EMQX Cloud használatával - a teljesen kezelt MQTT felhőszolgáltatási platform, amely csatlakoztatja a tömeges mennyiségű eszközöket és folyamatos adatfeldolgozást végez a rugalmas használati díj fizetési móddal.',
},
tryCloud: {
zh: '免费试用 EMQX Cloud',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the code review.

  1. The code patch looks good and consistent in terms of syntax and indentation.
  2. All the new strings added look relevant to the context as well as grammatically correct.
  3. There are no typos in the added strings.
  4. All the strings have been localized for different languages where needed.
  5. The strings are written using the appropriate capitalization and punctuation rules.

ja: 'EMQX Cloudは、EMQが提供する、膨大な数のIoTデバイスを接続し、リアルタイムにデータ処理を行うフルマネージドMQTTクラウドサービスプラットフォームで、従量課金制に対応しているのが特徴です。',
zh: '发掘物联网的强大能量,尝试使用 EMQX Cloud - 一款全托管的 MQTT 云服务平台,支持连接海量设备,使用灵活按量计费的方式实时处理数据,将物联网连接和数据处理变得更高效便捷。',
en: 'Unlock the power of IoT with EMQX Cloud - the fully managed MQTT cloud service platform that connects massive amounts of devices and processes real-time data with flexible pay-per-use billing.',
ja: 'EMQX Cloudを使用してIoTの強力な機能を発見しましょう。EMQX Cloudは、大規模なデバイスを接続し、リアルタイムデータを柔軟な使用料金で処理することができる完全に管理されたMQTTクラウドサービスプラットフォームです。',
},
tryCloud: {
zh: '免费试用 EMQX Cloud',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with code review:

  1. Ensure that the code is readable and organized.
  2. Check whether the code follows the appropriate coding conventions and standards.
  3. Check that the code does not have any syntax errors.
  4. Check if the code has been tested and validated properly.
  5. Check if the code is optimized for performance.
  6. Ensure that the code is secure and does not contain any vulnerabilities.
  7. Check if the code is compliant with the requirements and business logic.
  8. Check if the code is compatible with other existing systems.

@ysfscream ysfscream merged commit 1bbd5cb into main Mar 31, 2023
@ysfscream ysfscream deleted the dev/packages branch March 31, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop docs Add or update documents enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants