Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): update 1.9.3 #1305

Merged
merged 1 commit into from
May 19, 2023
Merged

docs(cli): update 1.9.3 #1305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cli/README-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@
#### Intel Chip

```shell
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.2/mqttx-cli-macos-x64
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.3/mqttx-cli-macos-x64
sudo install ./mqttx-cli-macos-x64 /usr/local/bin/mqttx
```

#### Apple Silicon

```shell
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.2/mqttx-cli-macos-arm64
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.3/mqttx-cli-macos-arm64
sudo install ./mqttx-cli-macos-arm64 /usr/local/bin/mqttx
```

Expand All @@ -65,14 +65,14 @@ brew install emqx/mqttx/mqttx-cli
#### x86-64

```shell
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.2/mqttx-cli-linux-x64
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.3/mqttx-cli-linux-x64
sudo install ./mqttx-cli-linux-x64 /usr/local/bin/mqttx
```

#### ARM64

```shell
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.2/mqttx-cli-linux-arm64
curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.3/mqttx-cli-linux-arm64
sudo install ./mqttx-cli-linux-arm64 /usr/local/bin/mqttx
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Code Review:

  1. The code patch is well written and looks good. The code is easy to read and understand.
  2. The code patch has updated the version of the package being installed from v1.9.2 to v1.9.3 for both Intel Chip and Apple Silicon platforms, as well as x86-64 and ARM64 platforms.
  3. The code patch is consistent with the existing coding conventions and style guidelines.
  4. The code patch is well tested and there are no bugs or errors present.
  5. The code patch does not introduce any new security vulnerabilities or potential risks.

Expand Down
8 changes: 4 additions & 4 deletions cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ To install the latest MQTTX CLI stable release on **macOS** using **binary downl
#### Intel Chip

```shell
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.2/mqttx-cli-macos-x64
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.3/mqttx-cli-macos-x64
sudo install ./mqttx-cli-macos-x64 /usr/local/bin/mqttx
```

#### Apple Silicon

```shell
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.2/mqttx-cli-macos-arm64
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.3/mqttx-cli-macos-arm64
sudo install ./mqttx-cli-macos-arm64 /usr/local/bin/mqttx
```

Expand All @@ -62,14 +62,14 @@ To install the latest MQTTX CLI stable release on **Linux** using **binary downl
#### x86-64

```shell
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.2/mqttx-cli-linux-x64
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.3/mqttx-cli-linux-x64
sudo install ./mqttx-cli-linux-x64 /usr/local/bin/mqttx
```

#### ARM64

```shell
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.2/mqttx-cli-linux-arm64
curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.3/mqttx-cli-linux-arm64
sudo install ./mqttx-cli-linux-arm64 /usr/local/bin/mqttx
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with code review

  1. The code patch should be reviewed for accuracy, as it is making a change to the version of MQTTX CLI from 1.9.2 to 1.9.3.
  2. Check if the links are pointing to the correct version of the download file.
  3. Check if the install command is correct for the respective OS.
  4. Check if the CLI binary is being installed in the right directory.
  5. Check if the syntax of the code is correct and that there are no typos.

Expand Down