Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(updateChecker):optimize automatic updates and add a progress bar #1314

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

ni00
Copy link
Contributor

@ni00 ni00 commented Jun 5, 2023

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

BUG_1: Will repeatedly pop up update prompt box.
BUG_2: Only check for the latest version(If the latest release is a prerelease, the update will stop).

Issue Number

Example: #123

What is the new behavior?

  1. Will fetch the tags list and check for the latest version.
  2. fix some bug about repeatedly pop up update prompt box.
  3. Add the ability to ignore updates to this version.
  4. Add a progress bar for updates.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

image

@ni00 ni00 requested review from ysfscream and Red-Asuka June 5, 2023 10:09
@ni00 ni00 changed the title refeator(updateChecker):fix some bugs and refeator code refactor(updateChecker):Fix bugs and refactor code Jun 6, 2023
@ni00 ni00 force-pushed the update branch 4 times, most recently from a7274d6 to 7591304 Compare June 7, 2023 00:56
@ni00
Copy link
Contributor Author

ni00 commented Jun 7, 2023

image image image image image

@ni00 ni00 marked this pull request as ready for review June 7, 2023 01:29
@Red-Asuka Red-Asuka assigned Red-Asuka and ni00 and unassigned Red-Asuka Jun 7, 2023
@Red-Asuka Red-Asuka added enhancement New feature or request fix Fix bug or issues desktop MQTTX Desktop labels Jun 7, 2023
@ni00 ni00 changed the title refactor(updateChecker):Fix bugs and refactor code refactor(updateChecker):optimize automatic updates and add a progress bar Jun 7, 2023
@ni00 ni00 force-pushed the update branch 3 times, most recently from 607f06c to 5d29e36 Compare June 7, 2023 06:29
src/main/updateChecker.ts Outdated Show resolved Hide resolved
@ni00 ni00 force-pushed the update branch 2 times, most recently from 8f929c4 to 6ce3d8b Compare June 8, 2023 02:56
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/lang/update.ts Outdated Show resolved Hide resolved
src/main/updateChecker.ts Outdated Show resolved Hide resolved
Comment on lines +41 to +42
width: 600,
height: 500,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an update window size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@Red-Asuka Red-Asuka merged commit 96d75ad into emqx:main Jun 12, 2023
@ni00 ni00 deleted the update branch June 14, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request fix Fix bug or issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants