-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(updateChecker):optimize automatic updates and add a progress bar #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni00
changed the title
refeator(updateChecker):fix some bugs and refeator code
refactor(updateChecker):Fix bugs and refactor code
Jun 6, 2023
ni00
force-pushed
the
update
branch
4 times, most recently
from
June 7, 2023 00:56
a7274d6
to
7591304
Compare
Red-Asuka
added
enhancement
New feature or request
fix
Fix bug or issues
desktop
MQTTX Desktop
labels
Jun 7, 2023
ni00
changed the title
refactor(updateChecker):Fix bugs and refactor code
refactor(updateChecker):optimize automatic updates and add a progress bar
Jun 7, 2023
ni00
force-pushed
the
update
branch
3 times, most recently
from
June 7, 2023 06:29
607f06c
to
5d29e36
Compare
Red-Asuka
reviewed
Jun 8, 2023
ni00
force-pushed
the
update
branch
2 times, most recently
from
June 8, 2023 02:56
8f929c4
to
6ce3d8b
Compare
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
ysfscream
reviewed
Jun 8, 2023
Comment on lines
+41
to
+42
width: 600, | ||
height: 500, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an update window size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
ysfscream
approved these changes
Jun 8, 2023
Red-Asuka
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
BUG_1: Will repeatedly pop up update prompt box.
BUG_2: Only check for the latest version(If the latest release is a prerelease, the update will stop).
Issue Number
Example: #123
What is the new behavior?
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information