-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): add enabled json highlight setting #1390
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
import { MigrationInterface, QueryRunner } from 'typeorm' | ||
|
||
export class jsonHighlight1691071794840 implements MigrationInterface { | ||
name = 'jsonHighlight1691071794840' | ||
|
||
public async up(queryRunner: QueryRunner): Promise<void> { | ||
await queryRunner.query(` | ||
CREATE TABLE "temporary_SettingEntity" ( | ||
"id" varchar PRIMARY KEY NOT NULL, | ||
"width" integer NOT NULL DEFAULT (1025), | ||
"height" integer NOT NULL DEFAULT (749), | ||
"autoCheck" boolean NOT NULL DEFAULT (1), | ||
"currentLang" varchar CHECK(currentLang IN ('zh', 'en', 'ja', 'tr', 'hu')) NOT NULL DEFAULT ('en'), | ||
"currentTheme" varchar CHECK(currentTheme IN ('light', 'dark', 'night')) NOT NULL DEFAULT ('light'), | ||
"maxReconnectTimes" integer NOT NULL DEFAULT (10), | ||
"autoResub" boolean NOT NULL DEFAULT (1), | ||
"syncOsTheme" boolean NOT NULL DEFAULT (0), | ||
"multiTopics" boolean NOT NULL DEFAULT (1), | ||
"jsonHighlight" boolean NOT NULL DEFAULT (1) | ||
) | ||
`) | ||
await queryRunner.query(` | ||
INSERT INTO "temporary_SettingEntity"( | ||
"id", | ||
"width", | ||
"height", | ||
"autoCheck", | ||
"currentLang", | ||
"currentTheme", | ||
"maxReconnectTimes", | ||
"autoResub", | ||
"syncOsTheme", | ||
"multiTopics" | ||
) | ||
SELECT "id", | ||
"width", | ||
"height", | ||
"autoCheck", | ||
"currentLang", | ||
"currentTheme", | ||
"maxReconnectTimes", | ||
"autoResub", | ||
"syncOsTheme", | ||
"multiTopics" | ||
FROM "SettingEntity" | ||
`) | ||
await queryRunner.query(` | ||
DROP TABLE "SettingEntity" | ||
`) | ||
await queryRunner.query(` | ||
ALTER TABLE "temporary_SettingEntity" | ||
RENAME TO "SettingEntity" | ||
`) | ||
await queryRunner.query(` | ||
CREATE TABLE "temporary_ScriptEntity" ( | ||
"id" varchar PRIMARY KEY NOT NULL, | ||
"name" varchar NOT NULL, | ||
"script" varchar NOT NULL, | ||
"type" varchar | ||
) | ||
`) | ||
await queryRunner.query(` | ||
INSERT INTO "temporary_ScriptEntity"("id", "name", "script", "type") | ||
SELECT "id", | ||
"name", | ||
"script", | ||
"type" | ||
FROM "ScriptEntity" | ||
`) | ||
await queryRunner.query(` | ||
DROP TABLE "ScriptEntity" | ||
`) | ||
await queryRunner.query(` | ||
ALTER TABLE "temporary_ScriptEntity" | ||
RENAME TO "ScriptEntity" | ||
`) | ||
} | ||
|
||
public async down(queryRunner: QueryRunner): Promise<void> { | ||
await queryRunner.query(` | ||
ALTER TABLE "ScriptEntity" | ||
RENAME TO "temporary_ScriptEntity" | ||
`) | ||
await queryRunner.query(` | ||
CREATE TABLE "ScriptEntity" ( | ||
"id" varchar PRIMARY KEY NOT NULL, | ||
"name" varchar NOT NULL, | ||
"script" varchar NOT NULL, | ||
"type" varchar DEFAULT (NULL) | ||
) | ||
`) | ||
await queryRunner.query(` | ||
INSERT INTO "ScriptEntity"("id", "name", "script", "type") | ||
SELECT "id", | ||
"name", | ||
"script", | ||
"type" | ||
FROM "temporary_ScriptEntity" | ||
`) | ||
await queryRunner.query(` | ||
DROP TABLE "temporary_ScriptEntity" | ||
`) | ||
await queryRunner.query(` | ||
ALTER TABLE "SettingEntity" | ||
RENAME TO "temporary_SettingEntity" | ||
`) | ||
await queryRunner.query(` | ||
CREATE TABLE "SettingEntity" ( | ||
"id" varchar PRIMARY KEY NOT NULL, | ||
"width" integer NOT NULL DEFAULT (1025), | ||
"height" integer NOT NULL DEFAULT (749), | ||
"autoCheck" boolean NOT NULL DEFAULT (1), | ||
"currentLang" varchar CHECK(currentLang IN ('zh', 'en', 'ja', 'tr', 'hu')) NOT NULL DEFAULT ('en'), | ||
"currentTheme" varchar CHECK(currentTheme IN ('light', 'dark', 'night')) NOT NULL DEFAULT ('light'), | ||
"maxReconnectTimes" integer NOT NULL DEFAULT (10), | ||
"autoResub" boolean NOT NULL DEFAULT (1), | ||
"syncOsTheme" boolean NOT NULL DEFAULT (0), | ||
"multiTopics" boolean NOT NULL DEFAULT (1) | ||
) | ||
`) | ||
await queryRunner.query(` | ||
INSERT INTO "SettingEntity"( | ||
"id", | ||
"width", | ||
"height", | ||
"autoCheck", | ||
"currentLang", | ||
"currentTheme", | ||
"maxReconnectTimes", | ||
"autoResub", | ||
"syncOsTheme", | ||
"multiTopics" | ||
) | ||
SELECT "id", | ||
"width", | ||
"height", | ||
"autoCheck", | ||
"currentLang", | ||
"currentTheme", | ||
"maxReconnectTimes", | ||
"autoResub", | ||
"syncOsTheme", | ||
"multiTopics" | ||
FROM "temporary_SettingEntity" | ||
`) | ||
await queryRunner.query(` | ||
DROP TABLE "temporary_SettingEntity" | ||
`) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to set the default value as false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, since this feature is a new highlight of this version, it would be meaningless if disabled by default. The performance issue during rendering may exist when the data size is relatively large, but the impact is insignificant for some common concurrent JSON data.