fix(cli):fix topic-alias-maximum error in cli connect #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysfscream
reviewed
Sep 28, 2023
Comment on lines
+98
to
+104
| let count = 0 | ||
| sender._write = (line, _enc, cb) => { | ||
| const { topic, opts, protobufPath, protobufMessageName, format } = pubOpts | ||
| count++ | ||
| let omitTopic = opts.properties?.topicAlias && count >= 2 | ||
| const publishMessage = processPublishMessage(line.trim(), protobufPath, protobufMessageName, format) | ||
| client.publish(topic, publishMessage, opts, cb) | ||
| client.publish(omitTopic ? '' : topic, publishMessage, opts, cb) |
There was a problem hiding this comment.
What is this for? If a topic alias is set after a line break, do we no longer need to enter or use the original publish topic?
There was a problem hiding this comment.
We only need to send the topic and topic alias together for the first time. The second time, we can directly use the topic alias to send, and the topic is set to "". The current multi-line send will carry the topic and topic alias each time, which does not comply with the mqtt protocol specification.
ysfscream
approved these changes
Sep 28, 2023
Red-Asuka
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
It's normal to use --topic-alias-maximum when pub.
Issue Number
#1398
What is the new behavior?
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information