-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:resolve data precision loss in JSON messages #1507
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4d856e8
fix(ci):fix deploy web by github action
ni00 1e3d44a
fix(desktop):resolve data precision loss in JSON messages
ni00 414c06b
fix(web):resolve data precision loss in JSON messages
ni00 6fb155f
fix(cli):resolve data precision loss in JSON messages
ni00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
const JSONBigNumber = require('json-bigint') | ||
const JSONBigInt = require('json-bigint')({ useNativeBigInt: true }) | ||
|
||
export const jsonParse: typeof JSON.parse = (...args: any[]) => { | ||
try { | ||
// When JSON only contains integers, use the native bigint type. | ||
return JSONBigInt.parse(...args) | ||
} catch (_error) { | ||
// When JSON contains floating-point numbers, use the bignumber library. | ||
// The numbers in the parsed JSON Object will be represented as BigNumber Objects. | ||
return JSONBigNumber.parse(...args) | ||
} | ||
} | ||
|
||
export const jsonStringify: typeof JSON.stringify = (...args: any[]) => { | ||
try { | ||
// When JSON only contains integers, use the native bigint type. | ||
return JSONBigInt.stringify(...args) | ||
} catch (_error) { | ||
// When JSON contains floating-point numbers, use the bignumber library. | ||
// Integers will be represented in scientific notation. | ||
return JSONBigNumber.stringify(...args) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
const JSONBigNumber = require('json-bigint') | ||
const JSONBigInt = require('json-bigint')({ useNativeBigInt: true }) | ||
|
||
export const jsonParse: typeof JSON.parse = (...args: any[]) => { | ||
try { | ||
// When JSON only contains integers, use the native bigint type. | ||
return JSONBigInt.parse(...args) | ||
} catch (_error) { | ||
// When JSON contains floating-point numbers, use the bignumber library. | ||
// The numbers in the parsed JSON Object will be represented as BigNumber Objects. | ||
return JSONBigNumber.parse(...args) | ||
} | ||
} | ||
|
||
export const jsonStringify: typeof JSON.stringify = (...args: any[]) => { | ||
try { | ||
// When JSON only contains integers, use the native bigint type. | ||
return JSONBigInt.stringify(...args) | ||
} catch (_error) { | ||
// When JSON contains floating-point numbers, use the bignumber library. | ||
// Integers will be represented in scientific notation. | ||
return JSONBigNumber.stringify(...args) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
const JSONBigNumber = require('json-bigint') | ||
const JSONBigInt = require('json-bigint')({ useNativeBigInt: true }) | ||
|
||
export const jsonParse: typeof JSON.parse = (...args: any[]) => { | ||
try { | ||
// When JSON only contains integers, use the native bigint type. | ||
return JSONBigInt.parse(...args) | ||
} catch (_error) { | ||
// When JSON contains floating-point numbers, use the bignumber library. | ||
// The numbers in the parsed JSON Object will be represented as BigNumber Objects. | ||
return JSONBigNumber.parse(...args) | ||
} | ||
} | ||
|
||
export const jsonStringify: typeof JSON.stringify = (...args: any[]) => { | ||
try { | ||
// When JSON only contains integers, use the native bigint type. | ||
return JSONBigInt.stringify(...args) | ||
} catch (_error) { | ||
// When JSON contains floating-point numbers, use the bignumber library. | ||
// Integers will be represented in scientific notation. | ||
return JSONBigNumber.stringify(...args) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be changed to ES6 import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a matter of code style. I will merge the PR first.