Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): remember the selected encode/decode type #1602

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

XL-YiBai
Copy link
Contributor

@XL-YiBai XL-YiBai commented Mar 15, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Restarting \ switching tools will change the default value of plaintext, resulting in other encoded messages will be garbled.

Issue Number

#903

What is the new behavior?

Remember the encoding/decoding type selected by the user.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@XL-YiBai XL-YiBai added feature This pr is a feature desktop MQTTX Desktop labels Mar 15, 2024
@XL-YiBai XL-YiBai requested a review from ysfscream March 15, 2024 06:46
@ysfscream ysfscream requested a review from Red-Asuka March 15, 2024 09:04
@ysfscream ysfscream added this to the v1.9.10 milestone Mar 15, 2024
@ysfscream ysfscream added the enhancement New feature or request label Mar 15, 2024
src/views/connections/ConnectionsDetail.vue Outdated Show resolved Hide resolved
src/views/connections/ConnectionsDetail.vue Outdated Show resolved Hide resolved
src/views/connections/ConnectionsDetail.vue Outdated Show resolved Hide resolved
@ysfscream
Copy link
Member

Thanks to @XL-YiBai for the contribution. However, I reviewed your code, which currently only works for the receiving side. Consider setting it up for the publishing side. Thanks.

@XL-YiBai
Copy link
Contributor Author

XL-YiBai commented Mar 15, 2024

Thanks to @XL-YiBai for the contribution. However, I reviewed your code, which currently only works for the receiving side. Consider setting it up for the publishing side. Thanks.

Hi, @ysfscream, I have reviewed the code for MsgPublish.vue and noticed that the ten recently sent messages will be stored, including their payloadType. After testing, the publishing side has already supported this feature.

image

@ysfscream
Copy link
Member

Oh, indeed. I now see that it's already included in the historical messages. That slipped my mind, appreciate your reminder. Let's move this PR forward for review. We'll conduct local testing, thank you.

@ysfscream ysfscream marked this pull request as ready for review March 18, 2024 09:37
@Red-Asuka Red-Asuka merged commit cffe9bf into emqx:main Mar 18, 2024
1 check passed
@XL-YiBai XL-YiBai deleted the my/main branch March 23, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants