-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(desktop): add save button for new & edit connection #1610
Conversation
@XL-YiBai Can you provide a screenshot after the modification? |
Looking good, can we also add this feature to the MQTTX Web? |
I just uploaded a demonstration video. 😆 |
Of course, I will complete it in my free time. |
Thank you for your contribution; it indeed looks like a valuable enhancement. However, for MQTTX, modifying parameters and saving without immediate connection isn't a frequent operation. Thus, we propose integrating this functionality via a dropdown menu to maintain a cleaner interface. Specifically, we can have the "Connect" button for standard operations on the left, and a dropdown menu on the right with an option for "Save Only". This approach benefits us by:
Resources:https://element-plus.org/zh-CN/component/dropdown.html the Right icon: the UI design: |
@ysfscream Thank you for your valuable suggestion and detailed design proposal. I will incorporate the suggested changes into the code. |
329a927
to
a798e26
Compare
@ni00, welcome to review this PR. Perhaps you could provide some more useful suggestions. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
When you want to make a new connection and fill in some (but not necessarly all) fields you can't temporailty save it and complement it later on. You can only choose Connect which is not always what you want. The same goes for editing connections.
Issue Number
#735
What is the new behavior?
When creating or editing connection information, the current information can be saved. Instead of clicking the
Connect
button to establish a connection.Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information