Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add env file to support configuration of BASE_URL #1619

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

DM1-1
Copy link
Contributor

@DM1-1 DM1-1 commented Apr 3, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Currently, BASE_URL is set in vue.config.js, and users may not be able to quickly find out how to modify BASE_URL.

Issue Number

#1575

What is the new behavior?

Support to modify configuration by exposing env files.
Distinguishing between the build environment and the docker environment.
Remove related useless step from ci.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Modes and Environment Variables | Vue CLI

Other information

Later, I will update readme to improve user-friendliness.

@DM1-1 DM1-1 added feature This pr is a feature CI/CD web MQTTX Web labels Apr 3, 2024
@DM1-1 DM1-1 linked an issue Apr 3, 2024 that may be closed by this pull request
@DM1-1 DM1-1 marked this pull request as ready for review April 3, 2024 08:24
@DM1-1 DM1-1 marked this pull request as draft April 7, 2024 10:16
@DM1-1 DM1-1 marked this pull request as ready for review April 8, 2024 02:19
@ysfscream ysfscream added this to the v1.10.0 milestone Apr 9, 2024
Copy link
Member

@ysfscream ysfscream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, LGTM. Thanks.

@ysfscream ysfscream merged commit 885253d into emqx:main Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD feature This pr is a feature web MQTTX Web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature] Set BASE_URL in MQTTX-Web on startup
3 participants