Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): support install mqttx cli one click #1712

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Jul 5, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The desktop version and the CLI version installations are relatively independent, and users need to download them separately in different scenarios.

Issue Number

Example: None

What is the new behavior?

After downloading the desktop version, allow users to directly install MQTTX CLI with one click if needed.

image image image image

image

image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream changed the title fix(desktop): support rebuild database when load connection error feat(desktop): support install mqttx cli one click Jul 5, 2024
@ysfscream ysfscream added this to the v1.10.1 milestone Jul 5, 2024
@ysfscream ysfscream requested review from Red-Asuka and XL-YiBai July 5, 2024 15:57
@ysfscream ysfscream self-assigned this Jul 5, 2024
@ysfscream ysfscream added feature This pr is a feature CLI MQTTX CLI desktop MQTTX Desktop labels Jul 5, 2024
@ysfscream ysfscream marked this pull request as ready for review July 5, 2024 15:58
@Red-Asuka
Copy link
Member

@ysfscream I see that the https://github.com/jorangreef/sudo-prompt project has been archived. Is there a more suitable library that is still being maintained?

@XL-YiBai XL-YiBai merged commit dbf09e7 into main Jul 8, 2024
1 check passed
@XL-YiBai XL-YiBai deleted the ysf/desktop branch July 8, 2024 02:08
@XL-YiBai XL-YiBai restored the ysf/desktop branch July 8, 2024 02:09
@Red-Asuka
Copy link
Member

@ysfscream I noticed that it needs to be done manually on Windows, but it can be achieved by configuring system environment variables. You can refer to https://stackoverflow.com/questions/59560042/how-to-append-values-to-the-path-environment-variable-in-nodejs.

@Red-Asuka Red-Asuka deleted the ysf/desktop branch July 8, 2024 02:10
@ysfscream
Copy link
Member Author

@ysfscream I see that the jorangreef/sudo-prompt project has been archived. Is there a more suitable library that is still being maintained?

I am still looking for a suitable replacement. Although the current project has been archived, it is still functional and stable, with 2 million weekly downloads on NPM. Please let me know if you have a suitable alternative in mind.

@ysfscream
Copy link
Member Author

@ysfscream I noticed that it needs to be done manually on Windows, but it can be achieved by configuring system environment variables. You can refer to stackoverflow.com/questions/59560042/how-to-append-values-to-the-path-environment-variable-in-nodejs.

Thank you for the suggestion! This looks very useful. I'll try implementing this in the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI desktop MQTTX Desktop feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants