Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): support setup cli to windows path #1715

Closed
wants to merge 3 commits into from
Closed

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Windows users can only run mqttx.exe manually. They should find the CLI exe file first on the system.

Issue Number

Example: None

What is the new behavior?

Add ${downloadPath}/mqttx.exe to the PATH to run mqttx.exe anywhere.

https://stackoverflow.com/questions/59560042/how-to-append-values-to-the-path-environment-variable-in-nodejs

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request feature This pr is a feature desktop MQTTX Desktop Windows labels Jul 8, 2024
@ysfscream ysfscream added this to the v1.10.1 milestone Jul 8, 2024
@ysfscream ysfscream requested review from Red-Asuka and XL-YiBai July 8, 2024 09:08
@ysfscream ysfscream self-assigned this Jul 8, 2024
@ysfscream ysfscream marked this pull request as draft July 8, 2024 15:44
@ysfscream
Copy link
Member Author

Waiting for real testing on the Windows system.

@ysfscream
Copy link
Member Author

@Red-Asuka Updating the PATH environment variable is a sensitive and dangerous operation that must be done cautiously. Therefore, we will temporarily not support using the PATH method to update the Windows CLI. I will close this PR.

@ysfscream ysfscream closed this Jul 10, 2024
@ysfscream ysfscream deleted the ysf/desktop branch July 10, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature Windows
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant