Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install zsh on unbuntu for developing #111

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

zhongwencool
Copy link
Contributor

No description provided.

@id
Copy link
Collaborator

id commented May 14, 2024

@zhongwencool missing get-zsh.sh script

@id
Copy link
Collaborator

id commented May 14, 2024

But if you install zsh package, may be you don't need that script in the Dockerfile?

@zhongwencool zhongwencool force-pushed the install-zsh-on-unbuntu-for-dev branch from 51060af to 260e735 Compare May 14, 2024 06:18
@zhongwencool
Copy link
Contributor Author

But if you install zsh package, may be you don't need that script in the Dockerfile?

The current bash is too basic, it's inconvenient to develop within it
I want to install ohmyzsh's plugins to make terminal experience delightful. :)
https://github.com/deluan/zsh-in-docker/blob/master/README.md

@id
Copy link
Collaborator

id commented May 14, 2024

But if you install zsh package, may be you don't need that script in the Dockerfile?

The current bash is too basic, it's inconvenient to develop within it I want to install ohmyzsh's plugins to make terminal experience delightful. :) https://github.com/deluan/zsh-in-docker/blob/master/README.md

What I meant is since you install zsh package in Ubuntu already, why would you need get-zsh.sh script.
But now I see that get-zsh.sh actually installs oh-my-zsh, not zsh itself.

id
id previously approved these changes May 14, 2024
ubuntu16.04/Dockerfile Outdated Show resolved Hide resolved
ubuntu16.04/Dockerfile Outdated Show resolved Hide resolved
ubuntu18.04/Dockerfile Outdated Show resolved Hide resolved
@id
Copy link
Collaborator

id commented May 14, 2024

To summarize my comments: I don't think you need to change any distro-specific Dockerfiles.
get-zsh.sh will install zsh in the final image for all distros + oh-my-zsh, and you can just add ENV ERL_AFLAGS="-kernel shell_history enabled" there.

@zhongwencool zhongwencool force-pushed the install-zsh-on-unbuntu-for-dev branch 3 times, most recently from 63a62d5 to bab6d94 Compare May 14, 2024 07:01
@zhongwencool zhongwencool force-pushed the install-zsh-on-unbuntu-for-dev branch from bab6d94 to a73935d Compare May 14, 2024 07:01
id
id previously approved these changes May 14, 2024
get-zsh.sh Outdated Show resolved Hide resolved
id
id previously approved these changes May 14, 2024
@id
Copy link
Collaborator

id commented May 14, 2024

deluan/zsh-in-docker#26

@zhongwencool
Copy link
Contributor Author

zhongwencool commented May 14, 2024

I've noticed that that repo is rarely updated. Maybe we can just copy that script directly into get-zsh.sh and maintain it ourselves?
It's MIT license.

@id
Copy link
Collaborator

id commented May 14, 2024

I'm testing this now #112.
If it works, we can just switch to our fork.

@id id force-pushed the install-zsh-on-unbuntu-for-dev branch from 40529d2 to c911cdb Compare May 14, 2024 08:06
alternatives --list | grep python && alternatives --set python /usr/bin/python3 || true

## cleanup
cd /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd /
cd ..

?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much the same in this case

@id id merged commit 68b4a11 into main May 14, 2024
80 checks passed
@id id deleted the install-zsh-on-unbuntu-for-dev branch May 14, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants