Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #1069

Closed
wants to merge 1 commit into from
Closed

WIP #1069

wants to merge 1 commit into from

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Sep 3, 2024

No description provided.

@Rory-Z Rory-Z force-pushed the fix/change-status-to-pointer branch 4 times, most recently from 983adeb to e18e023 Compare September 3, 2024 09:59
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (df0410b) to head (5da3621).

Files with missing lines Patch % Lines
controllers/apps/v2beta1/update_emqx_status.go 80.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
+ Coverage   76.52%   76.61%   +0.08%     
==========================================
  Files          69       69              
  Lines        6250     6264      +14     
==========================================
+ Hits         4783     4799      +16     
+ Misses       1232     1231       -1     
+ Partials      235      234       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z force-pushed the fix/change-status-to-pointer branch 2 times, most recently from 24a2f2b to 0b460eb Compare September 4, 2024 02:00
Signed-off-by: Rory Z <16801068+Rory-Z@users.noreply.github.com>
@Rory-Z Rory-Z force-pushed the fix/change-status-to-pointer branch from 0b460eb to 5da3621 Compare September 4, 2024 02:44
@Rory-Z Rory-Z closed this Sep 23, 2024
@Rory-Z Rory-Z deleted the fix/change-status-to-pointer branch September 23, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant