refactor opentelemetry_exporter #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeTupchiy
force-pushed
the
refactor-exporter-add-timeout
branch
2 times, most recently
from
dede23d
to
3ad2447
Compare
SergeTupchiy
force-pushed
the
refactor-exporter-add-timeout
branch
from
3ad2447
to
5862458
Compare
zmstone
reviewed
Nov 9, 2023
| {deps, [{grpcbox, ">= 0.0.0"}, | ||
| {tls_certificate_check, "~> 1.18"}, | ||
|
|
||
| {deps, [{grpc, {git, "https://github.com/emqx/grpc-erl", {tag, "0.6.11"}}}, |
There was a problem hiding this comment.
could you maybe add some words why this change in the PR description?
zmstone
reviewed
Nov 9, 2023
| [{scheme(Scheme), Host, Port, maps:get(ssl_options, Endpoint, [])} || | ||
| #{scheme := Scheme, host := Host, port := Port} = Endpoint <- Endpoints]. | ||
| %% Only called on a parsed and recomposed URL which is guaranteed to be a string | ||
| is_ssl([$h,$t,$t,$p,$s,$:,$/,$/ | _]) -> true; |
There was a problem hiding this comment.
nit;
you can do is_ssl("https://" ++ _) -> true;
zmstone
approved these changes
Nov 9, 2023
- use grpc-erl client instead of grpcbox - support exporter timeout - properly handle per-signal configuration - give precedence to directly passed exporter options over app env/ENV vars
SergeTupchiy
force-pushed
the
refactor-exporter-add-timeout
branch
from
5862458
to
043b18c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for chaning grpc client:
The request was just hanging and timing out...
I'm yet to report this issue to the upstream repo, but I decided that grpc-erl is ready to use and should be more resilient overall..