Skip to content

Commit

Permalink
Make test_dash_s_list_parsing more robust (#18336)
Browse files Browse the repository at this point in the history
Don't try to assert that the emcc stderr is empty.  The compiler can
generate message on stderr under certain circumstances.  For example
the `cache:INFO: generating system library: ...` messages.

Without this change this test fails if the cache is cleared right
before running it.
  • Loading branch information
sbc100 authored Dec 8, 2022
1 parent 005bb5b commit b313178
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/test_other.py
Original file line number Diff line number Diff line change
Expand Up @@ -9208,8 +9208,7 @@ def test_dash_s_list_parsing(self):
proc = self.run_process([EMCC, 'src.c', '-s', export_arg], stdout=PIPE, stderr=PIPE, check=not expected)
print(proc.stderr)
if not expected:
self.assertFalse(proc.stderr)
js = open('a.out.js').read()
js = read_file('a.out.js')
for sym in ('_a', '_b', '_c', '_d'):
self.assertContained(f'var {sym} = ', js)
else:
Expand Down

0 comments on commit b313178

Please sign in to comment.