-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error being overridden incorrectly on FS.Rename #11804
Comments
This was referenced Aug 4, 2020
Closed
kjpou1
added a commit
to dotnet/runtime
that referenced
this issue
Aug 4, 2020
* [browser][io] Workaround for issue MoveDirectory - Issue workaround while waiting for emscripten fix. #40305 - The following code checks for the existence of the source and destination directories which replaces the same code in the emscripten code. emscripten tracking issue: emscripten-core/emscripten#11804 * Update src/libraries/System.IO.FileSystem/src/System/IO/FileSystem.Unix.cs Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
I think that makes sense @kjpou1 , would you like to open a PR? |
This was referenced Aug 5, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this issue
Aug 10, 2020
* [browser][io] Workaround for issue MoveDirectory - Issue workaround while waiting for emscripten fix. dotnet#40305 - The following code checks for the existence of the source and destination directories which replaces the same code in the emscripten code. emscripten tracking issue: emscripten-core/emscripten#11804 * Update src/libraries/System.IO.FileSystem/src/System/IO/FileSystem.Unix.cs Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
mdh1418
pushed a commit
to dotnet/runtime
that referenced
this issue
Aug 10, 2020
* [browser][file system] Tests System.IO.FileSystem * Remove FileSystem from test project exclusions. * [browser][filesystem] Comment on skipped tests due to IO.Pipes not supported * [browser][filesystem] Comment on skipped tests due to monitor not supported * Address review comments * Address review comments on how to handle monitor PNSE * Update src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Add ActiveIssue for browser platform ``` [ActiveIssue("#39955", TestPlatforms.Browser)] public void NotFoundErrorIsExpected() ``` * Simplify test case with `PlatformDetection.IsSuperUser` as per review comment * Remove unused variable from tests * Browser platform volume does not limit each component of the path to a total of 255 characters. - Remove the test `DirectoryWithComponentLongerThanMaxComponentAsPath_ThrowsException` for Browser platform. - Add new test `DirectoryWithComponentLongerThanMaxComponentAsPath_BrowserDoesNotThrowsException` for Browser platform in case this check is added in the future. * Fix windows tests * Add ActiveIssue to test System.IO.Tests.DirectoryInfo_Name.CurrentDirectory - System.IO.Tests.DirectoryInfo_Name.CurrentDirectory does not pass because it is using Path.GetFileName on the current directory of "/". - See issue #39998 for more information * Add active issue for tests that need to support file locking. * Add active issue for tests that need to support file locking. * Browser volume does not have a limit on segments * Remove browser platform test * Remove active issue for NotFoundErrorIsExpected * Remove platform specific from SkippingHiddenFiles * Fix enumeration test errors failing from `HiddenFilesAreReturned`. - WebAssembly (BROWSER) has dirent d_type but is not identifying correctly but by returning UNKNOWN the managed code properly stats the file to detect if entry is directory or not. * Fix enumeration test errors failing from `HiddenFilesAreReturned`. - WebAssembly (BROWSER) has dirent d_type but is not identifying correctly but by returning UNKNOWN the managed code properly stats the file to detect if entry is directory or not. * Fix build for TARGET_WASM not defined * Address review comment by add check for IsWindows to IsSuperUser. * Address review comment by add check for IsWindows to IsSuperUser. * Platform Specific test for hidden files no longer needed. * Platform Specific test fno longer needed. * Use active issue for rename issue * ActiveIssue no longer needed - PR #40310 works around the issue for now while waiting for fix emscripten-core/emscripten#11804 / emscripten-core/emscripten#11812 * Use ActiveIssue for SettingUpdatesProperties * Use ActiveIssue for TimesIncludeMillisecondPart * Use ActiveIssue for ErrorHandlingTests failures * Use ActiveIssue for SetUptoNanoseconds * Use ActiveIssue for GetSetTimes test failures * Use ActiveIssue for tests failing with DirectoryNotFoundException * Use ActiveIssue for tests failing with UnauthorizedAccessException * Remove debugging statement from pal_io * Address type in CreateDirectory method name Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While renaming a file and if one of the parent paths do not exist the error code is being overwritten to EBUSY instead of reporting the actual error:
emscripten/src/library_fs.js
Line 729 in 126fa66
Suggested code that returns back the original error code is the following:
The text was updated successfully, but these errors were encountered: