-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New threads should receive DSO module via postMessage #18552
Comments
I guess the way this would work is that whenever a thread compiles a module it should postMessage that module to the other threads before loading (would this have to bounce through the main thread?). The onmessage handler would just stash the module in a data struct somewhere. When dlopen runs, it would check whether the module has already been received from another thread. |
I'm working on this change now, and I'm trying to figure out how best to test it. Its tricky because its supposed to be un-observable to the user when a given pthread loads the module. Any ideas for how to write this kind of test? |
Also test the preload plugin system under node. I was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. I was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. I was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. I was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. I was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. I was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Also test the preload plugin system under node. It was working previously but not covered by any of the test we run in CI. I'm hoping to unify this preloading system with the one planned as part of #18552.
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Any side modules that are loaded at the time of worker creation are shared with the worker via the initial postMessage. As a followup we should extend this to modules that are loaded after the worker is created but before the pthread runs (for example when a module is loaded while a worker is unused). Fixes: #18552
Right now we compile side modules on each thread but for module that have already been loaded at thread creation time this is not necessary.
The text was updated successfully, but these errors were encountered: