Fix a race condition in pthreads call proxying waiting #12243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
changed the title
kripken
added a commit
that referenced
this pull request
Sep 17, 2020
tlively
reviewed
Sep 17, 2020
Comment on lines
+422
to
+424
| // while also avoids a possible race condition, as call->operationDone | ||
| // can be set *after* we checked it but *before* we do the futex_wait. The | ||
| // futex_wait is not aware of call->operationDone which means if we wait |
There was a problem hiding this comment.
I'm confused. Isn't the whole point of futex_wait to do an atomic compare-and-block operation? Why wouldn't it be aware of call->operationDone?
There was a problem hiding this comment.
Ah, I think you're right, while this fixes the issue the diagnosis does look wrong.
This was referenced Sep 17, 2020
|
I have found the actual cause here, and will open a refactoring PR and then a fix PR shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not completely happy with this solution, see details in
the comment. ideas welcome!