Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper function for C++ exception formatting #16343
Add helper function for C++ exception formatting #16343
Changes from 15 commits
3cf21a0
2ea06c8
693f677
95ef456
103dca8
cc31016
5ca4f18
aa15cc8
493e22f
c7d1267
0231037
af456b1
e233943
83a1a4a
5e765ab
1235600
a83007e
5f19ef5
86b703b
a773e9b
16f160d
fbcf6da
8ad7932
68c129e
c11d036
9c0b0a6
439c09f
77376ea
8dad972
dcc15f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
@with_both_eh_sjlj
to this test?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you can also remove
DISABLE_EXCEPTION_CATCHING
below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work with wasm-exceptions. I am not sure how to make it work with
wasm-exceptions
, if you like I can look into it. It would probably be entertaining. But I think it should be a separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, can you open a bug about that so that we remember to get it fixed. I imagine @aheejin will want it to work for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #16380 which is where I got stuck in the wasm-exceptions case.