embind: Remove str-to-func eval of named function factory #18748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
embind_computed_property_name
branch
from
8a702c5
to
4913805
Compare
sbc100
changed the title
kripken
reviewed
Feb 14, 2023
kripken
reviewed
Feb 14, 2023
For support for this feature see: ttps://caniuse.com/mdn-javascript_operators_object_initializer_computed_property_names Based on #17296
sbc100
force-pushed
the
embind_computed_property_name
branch
from
4913805
to
8094e17
Compare
RReverser
added a commit
to RReverser/emscripten
that referenced
this pull request
Oct 18, 2023
Further simplification of createNamedFunction on top of emscripten-core#18748: we can avoid extra JS wrapper by setting `name` of the function directly. This is only supported via "configuring" it by `Object.defineProperty` rather than plain assignment, but otherwise has exactly same effect - it sets debug name of the function in-place. Also, ever since emscripten-core#18748 switched away from `eval`, there is no requirement for the function name to be "legal" - we can set it to the plain demangled string, making debug names even more readable.
RReverser
added a commit
that referenced
this pull request
Oct 18, 2023
Further simplification of createNamedFunction on top of #18748: we can avoid extra JS wrapper by setting `name` of the function directly. This is only supported via "configuring" it by `Object.defineProperty` rather than plain assignment, but otherwise has exactly same effect - it sets debug name of the function in-place. Also, ever since #18748 switched away from `eval`, there is no requirement for the function name to be "legal" - we can set it to the plain demangled string, making debug names even more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For support for this feature see:
https://caniuse.com/mdn-javascript_operators_object_initializer_computed_property_names
Based on #17296