Move loading of initial dynamic libraries to before run. NFC
#19450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
runrun. NFC
sbc100
force-pushed
the
move_loadDylibs
branch
2 times, most recently
from
51912b9 to
e9db663
Compare
Previously we were calling `loadDylibs` in the `run` function but we can call it earlier as soon as the main module is instantiated. This saves a little on code size since it relies on the existing `runDependencies` mechanism. Split out from #19390
kripken
approved these changes
May 25, 2023
| @@ -21,6 +21,7 @@ | |||
| // new function with an '_', it will not be found. | |||
|
|
|||
| mergeInto(LibraryManager.library, { | |||
|
|
|||
| if (!ENVIRONMENT_IS_PTHREAD || runtimeInitialized) | ||
| #endif | ||
| // If the runtime has already been initialized we set the stack limits | ||
| // now. Othwerwise this is delayed until `setDylinkStackLimits` is |
There was a problem hiding this comment.
Suggested change
| // now. Othwerwise this is delayed until `setDylinkStackLimits` is | |
| // now. Otherwise this is delayed until `setDylinkStackLimits` is |
Indeed, there are some subtle timing/ordering details here, but I'm really glad your pushed me to factor this PR out of the other once, since it helped me understand them better and make this PR into something that is good to land regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were calling
loadDylibsin therunfunction but we can call it earlier as soon as the main module is instantiated. This saves a little on code size since it relies on the existingrunDependenciesmechanism.Split out from #19390