Note newly enabled features in LLVM in ChangeLog #21853
Conversation
llvm/llvm-project#80923 enabled multivalue and reference-types by default. Even though this is an LLVM change, given that we release emsdk with all LLVM/Binaryen/Emscripten versions, it could be worth mentioning in the ChangeLog.
ChangeLog.md
Outdated
| @@ -24,6 +24,9 @@ See docs/process.md for more on how version tagging works. | |||
| of pthread builds so that is generated alongside the main JavaScript file. | |||
| See #21701. () | |||
| - `-sASYNCIFY=2` is setting now deprecated, use `-sJSPI` instead. | |||
| - LLVM now enables multivalue and reference-types features by default. Enabling | |||
There was a problem hiding this comment.
Perhaps phrase this as something that emscripten now supports? Maybe "Due to and upstream llvm change, the x and y features are not enabled by default in emscripten"?
|
Should we also update Line 1884 in 63c648f |
Good point. Maybe we should just go to 18 since that is LTS. Do all our min browser versions support reference types? |
Yeah, I'm not totally sure we need/want to do this. Especially since we are not going to actually be generating any reference types by default. |
|
I'll then land this for now. |
I submitted emscripten-core#21853 before landing llvm/llvm-project#80923, so the previous version (3.1.59) was released before the LLVM change actually landed. And then we decided to disable reference-types temporarily (llvm/llvm-project#90792) while the node version is being resolved (emscripten-core/emsdk#1173 (comment)). This moves the entry to the current release and only mentions multivalue is the newly enabled feature.
I submitted #21853 before landing llvm/llvm-project#80923, so the previous version (3.1.59) was released before the LLVM change actually landed. And then we decided to disable reference-types temporarily (llvm/llvm-project#90792) while the node version is being resolved (emscripten-core/emsdk#1173 (comment)). This moves the entry to the current release and only mentions multivalue is the newly enabled feature.
llvm/llvm-project#80923 enabled multivalue and reference-types by default. Even though this is an LLVM change, given that we release emsdk with all LLVM/Binaryen/Emscripten versions, it could be worth mentioning in the ChangeLog.