Move setjmp/longjmp helper functions and globals to compiler_rt_wasm … #7203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…library Previously these have been generated by LLVM during codegen but this doesn't work once we have separate compilation. See LLVM change: https://reviews.llvm.org/D49208
jgravelle-google
approved these changes
Sep 28, 2018
system/lib/compiler-rt/extras.c
Outdated
| } | ||
|
|
||
| void getTempRet0(int value) { | ||
| __tempRet0 = value; |
There was a problem hiding this comment.
Maybe
int getTempRet0() {
return __tempRet0;
}| @@ -467,6 +467,8 @@ def create_wasm_compiler_rt(libname): | |||
| 'ashldi3.c', 'fixdfdi.c', 'floatdidf.c', 'lshrdi3.c', 'moddi3.c', | |||
| 'trunctfdf2.c', 'trunctfsf2.c', 'umoddi3.c', 'fixunsdfdi.c', 'muldi3.c', | |||
| 'divdi3.c', 'divmoddi4.c', 'udivdi3.c', 'udivmoddi4.c']) | |||
| files += files_in_path(path_components=['system', 'lib', 'compiler-rt'], | |||
There was a problem hiding this comment.
Maybe move+rename extras.c to system/lib/compiler-rt/lib/wasm_extras.c
There was a problem hiding this comment.
Yeah.. I thought about giving it a different name. Perhaps moving it up one level to its not in the compiler-rt source directory at all.
The thing is we have libc/extra.c so I thought it would be good to be consistent with that.
[skip ci]
earl
pushed a commit
to earl/llvm-mirror
that referenced
this pull request
Oct 2, 2018
…criptenEHSjLj Previously we were creating weakly defined helper function in each translation unit: - setThrew - setTempRet0 Instead we now assume these will be provided at link time. In emscripten they are provided in compiler-rt: emscripten-core/emscripten#7203 Additionally we previously created three global variable which are also now required to exist at link time instead. - __THREW__ - _threwValue - __tempRet0 Differential Revision: https://reviews.llvm.org/D49208 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@343640 91177308-0d34-0410-b5e6-96231b3b80d8
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Oct 10, 2018
PR emscripten-core#7203 added some functions used for emscripten EH and they are now exported. They can be DCE'd if they are not used but not at -O1.
aheejin
added a commit
that referenced
this pull request
Oct 11, 2018
PR #7203 added some functions used for emscripten EH and they are now exported. They can be DCE'd if they are not used but not at -O1.
llvm-git-migration
pushed a commit
to llvm-git-prototype/llvm
that referenced
this pull request
Nov 6, 2018
…criptenEHSjLj Previously we were creating weakly defined helper function in each translation unit: - setThrew - setTempRet0 Instead we now assume these will be provided at link time. In emscripten they are provided in compiler-rt: emscripten-core/emscripten#7203 Additionally we previously created three global variable which are also now required to exist at link time instead. - __THREW__ - _threwValue - __tempRet0 Differential Revision: https://reviews.llvm.org/D49208 llvm-svn=343640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…library
Previously these have been generated by LLVM during codegen
but this doesn't work once we have separate compilation.
See LLVM change: https://reviews.llvm.org/D49208