Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node.js 18.18.0 #1284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RobLoach
Copy link

@RobLoach RobLoach commented Oct 8, 2023

This aims to update to Node.js 18.18.0, as discussed in #1173 . I'm not sure if it updates everything needed, but does update the manifest, as well all references. We'll need to do some aggressive testing to ensure it's correct.

@sbc100
Copy link
Collaborator

sbc100 commented Oct 9, 2023

Out of interest, is there some reason that you care about this mostly-internally-used version of node? It shouldn't effect the version of node on which you can run the generated code.

Are you perhaps relying on the emsdk-provided version of node to run your generated code in some environment? (testing? production?)

@RobLoach
Copy link
Author

RobLoach commented Oct 10, 2023

Node.js 16 was EOLed last month: https://nodejs.dev/en/about/releases/

While it's not critical to update it, it would be good to push it forwards within emsdk. Getting the following error since the install is not on Emscripten's release-build deps storage:

Installing tool 'node-18.18.0-64bit'..
Error: Downloading URL 'https://storage.googleapis.com/webassembly/emscripten-releases-builds/deps/node-v18.18.0-linux-x64.tar.xz': HTTP Error 404: Not Found
error: installation failed!

@sbc100
Copy link
Collaborator

sbc100 commented Oct 10, 2023

Node.js 16 was EOLed last month: https://nodejs.dev/en/about/releases/

While it's not critical to update it, it would be good to push it forwards within emsdk.

emsdk does not depend on security updates or support for nodejs. We use node internally as part of compiler process but it not exposed directly to end users or running untrusted code. For this reason, I consider the end-of-life argument less relevant to our project than most.

The downside of dropping support for distros like Ubuntu/Bionic seems more real to me (node v18 doesn't support the version of glibc that ships in Ubuntu/Bionic: nodesource/distributions#1392).

Getting the following error since the install is not on Emscripten's release-build deps storage:

Installing tool 'node-18.18.0-64bit'..
Error: Downloading URL 'https://storage.googleapis.com/webassembly/emscripten-releases-builds/deps/node-v18.18.0-linux-x64.tar.xz': HTTP Error 404: Not Found
error: installation failed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants