Replaced ModuleItem::row() with BaseTreeItem::getOwnRow()

emsec · Apr 17, 2024 · c061ccc · c061ccc
1 parent 0141426
commit c061ccc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 17 deletions.
diff --git a/plugins/gui/include/gui/module_model/module_item.h b/plugins/gui/include/gui/module_model/module_item.h
@@ -79,13 +79,6 @@ namespace hal
          */
         QVariant getData(int column) const override;
 
-        /**
-         * Gets the index of this ModuleItem in the list of children ModuleItems of its parent.
-         *
-         * @returns the index in the parents ModuleItem children list
-         */
-        int row() const;
-
         /**
          * Gets the name of the netlist item this ModuleItem represents.
          *

diff --git a/plugins/gui/src/module_model/module_item.cpp b/plugins/gui/src/module_model/module_item.cpp
@@ -42,14 +42,6 @@ ModuleItem::ModuleItem(const u32 id, const TreeItemType type) :
         }
     }
 
-    int ModuleItem::row() const
-    {
-        BaseTreeItem* parent = getParent();
-        if (!parent) return 0;
-        return parent->getRowForChild(this);
-    }
-
-
     void ModuleItem::appendExistingChildIfAny(const QMap<u32,ModuleItem*>& moduleMap)
     {
         if(mItemType != TreeItemType::Module) // only module can have children

diff --git a/plugins/gui/src/module_model/module_model.cpp b/plugins/gui/src/module_model/module_model.cpp
@@ -270,7 +270,7 @@ namespace hal
 
         QModelIndex index = getIndexFromItem(parentItem);
 
-        int row = itemToRemove->row();
+        int row = itemToRemove->getOwnRow();
 
         mIsModifying = true;
         beginRemoveRows(index, row, row);
@@ -648,7 +648,7 @@ namespace hal
                     moduleItemToBeMoved = submItem;
                     QModelIndex index = getIndexFromItem(oldParentItem);
 
-                    int row = submItem->row();
+                    int row = submItem->getOwnRow();
 
                     mIsModifying = true;
                     beginRemoveRows(index, row, row);