Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated code documentation and changelog #594

Merged
merged 2 commits into from
Oct 29, 2024
Merged

updated code documentation and changelog #594

merged 2 commits into from
Oct 29, 2024

Conversation

Skaleee
Copy link
Contributor

@Skaleee Skaleee commented Oct 28, 2024

No description provided.

Copy link
Contributor

@joern274 joern274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for excellent documentation.

Please remove comment from line 331 in netlist_internal_manager.cpp

Keep in mind that things are already settled in the core when the events are issued. Request to access the new gate e.g. to add it as child in module tree are safe. Swapping the events would not make life easier, you would still need the information to which module the gate was assigned before you can place the element. Having a gate which is not assigned is not an option, not even as intermediate state.

@Skaleee
Copy link
Contributor Author

Skaleee commented Oct 28, 2024

Done 👍

@joern274 joern274 merged commit 909b4c4 into master Oct 29, 2024
3 of 4 checks passed
@joern274 joern274 deleted the doc/update_doc branch October 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants