Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel the changed information when closing or pressing Escape #47

Closed
GerdonAbbink opened this issue Jun 12, 2022 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@GerdonAbbink
Copy link

Not sure if this is possible using the close button of the dialog.

I would like to see another dialog asking if you want to discard the changed settings whenever you try to close the dialog or when pressing Escape.

This FR is the result of #46 after figuring out pressing Escape saves the settings.

@GerdonAbbink
Copy link
Author

GerdonAbbink commented Jun 13, 2022

With the new information from the comment of @emtrax-ltd in #46 I changed this to a bug report.

Whenever the close button is used it does not save the information like in the "Machine Settings" dialog.

@GerdonAbbink GerdonAbbink changed the title Feature Request: Cancel the changed information when closing or pressing Escape Bug Report: Cancel the changed information when closing or pressing Escape Jun 13, 2022
@emtrax-ltd
Copy link
Owner

I will check and fix that.

@emtrax-ltd emtrax-ltd added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 16, 2022
@emtrax-ltd emtrax-ltd changed the title Bug Report: Cancel the changed information when closing or pressing Escape Cancel the changed information when closing or pressing Escape Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants