Fix(stylelint issues): Adjusting stylelint rule settings. #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robherba
changed the title
callinmullaney
added
🎉 Passes Code Review
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since there was an update to Node 20, the Stylelin version were upgraded too, this is not happening on Compound, this PR fixes the new warnings the are being displayed because of those upgrades.
This PR must be tested together with this PR
How to review this pull request
Create Drupal Project:
composer create-project drupal/recommended-project [PROJECT_NAME] --no-interactionMove into the project directory
cd [PROJECT_NAME]Install Emulsify client globally
npm install -g @emulsify/cliInitialize your theme with emulsify
emulsify init --checkout=fix-stylelint-issues "[THEME NAME]"Install the version of Drupal componentst works with Drupal 10
composer require 'drupal/components:^3.0@beta'Install the version of emulsify_twig that work with Drupal 10
composer require 'drupal/emulsify_twig^4.0'Move into the theme directory
cd web/themes/custom/[THEME NAME]Install Compound System
emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout fix-stylelint-issuesVerify storybook and scss compiling can run and there are no stylelint issues and warnings
npm install && npm run develop