Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pager: Current page link lacks 4.5 to 1 color contrast #171

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Dec 20, 2024

Summary

Update design tokens of Pager to fix color contrast issue in active current page

How to review this pull request

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 306f332
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/6765a9fc84fbad000836f90e
😎 Deploy Preview https://deploy-preview-171--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mariannuar mariannuar self-assigned this Dec 20, 2024
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Dec 20, 2024
@callinmullaney callinmullaney added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Jan 3, 2025
Copy link
Contributor

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks good to me! Thanks for the follow up on this from the accessibility review :shipit:

@mariannuar mariannuar merged commit e2dd9b2 into main Jan 8, 2025
4 checks passed
@mariannuar mariannuar deleted the emulsif--441-fix-color-contrast-in-pager branch January 8, 2025 18:06
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants