Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 to 0.4.3 #231

Merged
merged 6 commits into from
Jan 13, 2021
Merged

PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 to 0.4.3 #231

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7206fad
PLAT-129601: Upgrade @pmmmwh/react-refresh-webpack-plugin module from…
hong6316 Dec 30, 2020
8d08695
Merge branch 'feature/react17' into feature/PLAT-129601
hong6316 Dec 31, 2020
e0cd003
Update CHANGELOG.md
hong6316 Dec 31, 2020
c8fec71
Update package-lock.json
hong6316 Dec 31, 2020
f639b60
Update commands/eject.js (for fixing lint error)
hong6316 Dec 31, 2020
06bb4ad
Update package.json 2
hong6316 Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 28 additions & 29 deletions commands/eject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,36 +69,35 @@ function displayHelp() {

function validateEject() {
return prompts({
type: 'confirm',
name: 'shouldEject',
message: 'Are you sure you want to eject? This action is permanent.',
default: false
})
.then(answer => {
if (!answer.shouldEject) {
console.log(chalk.cyan('Close one! Eject aborted.'));
return {abort: true};
} else {
checkGitStatus();
type: 'confirm',
name: 'shouldEject',
message: 'Are you sure you want to eject? This action is permanent.',
default: false
}).then(answer => {
if (!answer.shouldEject) {
console.log(chalk.cyan('Close one! Eject aborted.'));
return {abort: true};
} else {
checkGitStatus();

// Make shallow array of files paths
const files = assets.reduce((list, dir) => {
return list.concat(
fs
.readdirSync(dir.src)
// set full relative path
.map(file => ({
src: path.join(dir.src, file),
dest: path.join(dir.dest, file)
}))
// omit dirs from file list
.filter(file => fs.lstatSync(file.src).isFile())
);
}, []);
files.forEach(verifyAbsent);
return {files};
}
});
// Make shallow array of files paths
const files = assets.reduce((list, dir) => {
return list.concat(
fs
.readdirSync(dir.src)
// set full relative path
.map(file => ({
src: path.join(dir.src, file),
dest: path.join(dir.dest, file)
}))
// omit dirs from file list
.filter(file => fs.lstatSync(file.src).isFile())
);
}, []);
files.forEach(verifyAbsent);
return {files};
}
});
}

function checkGitStatus() {
Expand Down
22 changes: 12 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@babel/runtime": "7.12.1",
"@enact/dev-utils": "3.1.0",
"@enact/template-moonstone": "3.1.0",
"@pmmmwh/react-refresh-webpack-plugin": "0.3.3",
"@pmmmwh/react-refresh-webpack-plugin": "0.4.3",
"@typescript-eslint/eslint-plugin": "4.5.0",
"@typescript-eslint/parser": "4.5.0",
"@wojtekmaj/enzyme-adapter-react-17": "0.3.2",
Expand Down Expand Up @@ -132,6 +132,7 @@
"fsevents": "^2.1.3"
},
"peerDependencies": {
"react": ">= 16",
MikyungKim marked this conversation as resolved.
Show resolved Hide resolved
"typescript": "^3.2.1"
},
"peerDependenciesMeta": {
Expand Down