2.4.1 release

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.4.1 (September 4, 2019)
+
+* `SnapshotPlugin`:  Fixed V8 snapshotting when `ilib` external package is not found.
+
 # 2.4.0 (August 12, 2019)
 
 * Redesigned `option-parser` with encapsulated theme option support and environment variable overriding.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@enact/dev-utils",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "A collection of development utilities for Enact apps.",
   "main": "index.js",
   "author": "Jason Robitaille <jason.robitaille@lge.com>",

plugins/SnapshotPlugin/index.js

@@ -55,11 +55,18 @@ class SnapshotPlugin {
 		compiler.hooks.v8Snapshot = new SyncHook([]);
 
 		// Ignore packages that don't exists so snapshot helper can skip them
-		['ilib', '@enact/i18n', '@enact/moonstone', '@enact/core/snapshot'].forEach(lib => {
-			if (!fs.existsSync(path.join(app, 'node_modules', lib))) {
-				new IgnorePlugin(new RegExp(lib)).apply(compiler);
-			}
+		const ignoreContext = path.dirname(SnapshotPlugin.helperJS);
+		const missing = lib => !fs.existsSync(path.join(app, 'node_modules', lib));
+		const filter = lib => (resource, context) => {
+			return resource.startsWith(lib) && context === ignoreContext;
+		};
+		['@enact/i18n', '@enact/moonstone', '@enact/core/snapshot'].filter(missing).forEach(p => {
+			new IgnorePlugin({checkResource: filter(p)}).apply(compiler);
 		});
+		// ilib can be aliased to @enact/i18n/ilib, so verify both are missing before ignoring
+		if (['ilib', '@enact/i18n/ilib'].every(missing)) {
+			new IgnorePlugin({checkResource: filter('ilib')}).apply(compiler);
+		}
 
 		// Redirect external 'react-dom' import/require statements to the snapshot helper
 		compiler.hooks.normalModuleFactory.tap('SnapshotPlugin', factory => {