Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRN-851: Remove hasPointerMoved from spotlight and spotlight/SpotlightContainerDecorator #2954

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

juwonjeong
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Delete guard code related to mouse(pointer) which checks if the pointer actually moves when mouse events emit.
(Related PR: #2823)

Resolution

Remove hasPointerMoved from spotlight and spotlight/SpotlightContainerDecorator

Additional Considerations

Check related UI test changes in Sandstone(https://github.com/enactjs/sandstone/tree/feature/WRN-851), Moonstone(https://github.com/enactjs/moonstone/tree/feature/WRN-851)

Links

WRN-851

Comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2954 (b4a60e7) into develop (f779d43) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2954      +/-   ##
===========================================
- Coverage    47.47%   47.47%   -0.01%     
===========================================
  Files          171      171              
  Lines         9423     9422       -1     
  Branches      2350     2350              
===========================================
- Hits          4474     4473       -1     
  Misses        3842     3842              
  Partials      1107     1107              
Impacted Files Coverage Δ
.../SpotlightContainerDecorator/SpotlightContainer.js 81.35% <ø> (-0.32%) ⬇️
packages/spotlight/src/spotlight.js 28.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f779d43...b4a60e7. Read the comment docs.

@juwonjeong juwonjeong changed the title Feature/wrn 851 WRN-851: Remove hasPointerMoved from spotlight and spotlight/SpotlightContainerDecorator Oct 19, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 28, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants