WRO-8481: Fixed MarqueeDecorator to restart animation properly with React 18
#3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate when restarting animation Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Codecov Report
@@ Coverage Diff @@
## develop #3075 +/- ##
===========================================
- Coverage 48.10% 48.10% -0.01%
===========================================
Files 171 171
Lines 9716 9717 +1
Branches 2609 2609
===========================================
Hits 4674 4674
- Misses 3955 3956 +1
Partials 1087 1087
Continue to review full report at Codecov.
|
jeonghee27
reviewed
Jul 22, 2022
jeonghee27
approved these changes
Jul 22, 2022
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
MikyungKim
changed the title
MarqueeDecorator to restart animation properly with React 18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Checklist
Issue Resolved / Feature Added
When marquee applied to item related components, marquee cannot restart animation after completes its marquee once.
When marquee completes its marquee once, restartAnimation() func in marqueeDecorator called to set animating state to be false and then called start() func. As react batchs its state, animating state is true when start() executed and it caused animation to be stopped.
Resolution
Use flushSync in marqueeDecorator to synchronously update animating state to be false.
Additional Considerations
Links
WRO-8481
Comments