Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-6697: Fix node_js to use lts version only on travis #3289

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Nov 1, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

npm intall not working on node v23 because of node-canvas
https://github.com/enactjs/sandstone/pull/1723/checks?check_run_id=31623413345

So we decided to change the node version to lts/*

Resolution

Fix node_js to use lts version only on travis

Additional Considerations

Links

WRR-6697

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (d19e60c) to head (7aab593).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3289   +/-   ##
========================================
  Coverage    82.30%   82.30%           
========================================
  Files          152      152           
  Lines         7091     7091           
  Branches      1867     1867           
========================================
  Hits          5836     5836           
  Misses         985      985           
  Partials       270      270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkylerBaek
Copy link
Member

Note that lts version is 22 as of now. Due to unstable dependencies whenever a major version of node, we'd like to use lts for Travis CI.

@SkylerBaek SkylerBaek merged commit ced4483 into develop Nov 5, 2024
7 checks passed
@SkylerBaek SkylerBaek deleted the feature/WRR-6697 branch November 5, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants