Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/develop' into feature/WRR-5260
Browse files Browse the repository at this point in the history
  • Loading branch information
daniel-stoian-lgp committed Dec 19, 2024
2 parents 6102ddd + de22a0f commit a788ad0
Show file tree
Hide file tree
Showing 146 changed files with 6,877 additions and 10,043 deletions.
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
### Checklist

* [ ] I have read and understand the [contribution guide](http://enactjs.com/docs/developer-guide/contributing/)
* [ ] A [CHANGELOG entry](http://enactjs.com/docs/developer-guide/contributing/changelogs/) is included
* [ ] I have read and understand the [contribution guide](https://enactjs.com/docs/developer-guide/contributing/)
* [ ] A [CHANGELOG entry](https://enactjs.com/docs/developer-guide/contributing/changelogs/) is included
* [ ] At least one test case is included for this feature or bug fix
* [ ] Documentation was added or is not needed
* [ ] This is an API breaking change
Expand Down
55 changes: 54 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ The following is a curated list of changes in the Enact sandstone module, newest

### Added

- `sandstone/Icon` supported icon list, adding new icon `calibration`

### Fixed

- `sandstone/Scroller` to focus properly when the spottable node is bigger than the size of viewport by voice control
- `sandstone/Scroller` to prevent the native scrolling behavior caused by keydown events when a popup is open

## [3.0.0-alpha.3] - 2024-12-02

### Added

- `sandstone/Icon` supported icon list, adding new icons `ai`, `alert01`, and `alert02`
- `sandstone/PageViews` prop `autoFocus` to set whether focus element automatically or not
- `sandstone/PageViews.Page` and `sandstone/QuickGuidePanels.Panel` prop `aria-label`
Expand All @@ -22,6 +33,48 @@ The following is a curated list of changes in the Enact sandstone module, newest
- `sandstone/Scroller` with `editable` prop to move an item via 5-way keys properly in pointer mode
- `sandstone/Slider` to not show console error when dragging with touch

## [2.9.5] - 2024-11-19

### Added

- `sandstone/Icon` supported icon list, adding new icons `ai`, `alert01`, and `alert02`

### Fixed

- `sandstone/ContextualPopupDecorator` to update popup position properly when the screen orientation change
- `sandstone/Input` keypad layout when `type` prop is `number` or `passwordnumber` and the screen is in portrait mode or `popupType` prop is `overlay` and in large text mode
- `sandstone/Slider` to not show console error when dragging with touch

## [2.7.19] - 2024-11-15

### Fixed

- `sandstone/ContextualPopupDecorator` to update popup position properly when the screen orientation change
- `sandstone/Input` keypad layout when `type` prop is `number` or `passwordnumber` and the screen is in portrait mode or `popupType` prop is `overlay` and in large text mode

## [2.9.4] - 2024-10-29

### Fixed

- `sandstone/IconItem` to restart marquee after done editing in `sandstone/Scroller` with `editable` prop
- `sandstone/PageViews` and `sandstone/QuickGuidePanels` dot page indicators to be aligned center
- `sandstone/Scroller` to focus content area properly on supported platforms when `focusableScrollbar` prop is `byEnter`
- `sandstone/Scroller` with `editable` prop to move an item via 5-way keys properly in pointer mode

## [2.9.3] - 2024-10-15

### Added

- `sandstone/MediaControls` props `jumpBackwardAriaLabel` and `jumpForwardAriaLabel` to override aria-label of jumpButtons
- `sandstone/PageViews` prop `autoFocus` to set whether focus element automatically or not

### Fixed

- `sandstone/PageViews` to not clip the shadow of navigation buttons when `fullContents` prop is `true`
- `sandstone/Scroller` to focus the topmost element after scroll by voice control
- `sandstone/Scroller` to read out properly when `sandstone/Panels` has `sandstone/Scroller` with `focusableScrollbar`
- `sandstone/VideoPlayer` to show only the mini feedback when pressing play/pause key

## [3.0.0-alpha.2] - 2024-10-08

### Added
Expand Down Expand Up @@ -267,7 +320,7 @@ No significant changes.

### Fixed

- `sandstone/Dropdown' to focus properly the first option and the last option via page up and page down
- `sandstone/Dropdown` to focus properly the first option and the last option via page up and page down
- `sandstone/QuickGuidePanels` to not lose focus when the last view is displayed

## [2.7.5] - 2023-08-04
Expand Down
2 changes: 1 addition & 1 deletion Checkbox/Checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const CheckboxBase = kind({

computed: {
className: ({indeterminate, selected, standalone, styler}) => styler.append({selected, standalone, indeterminate}),
children: ({indeterminate, indeterminateIcon, children}) => (indeterminate ? indeterminateIcon : children) // This controls which icon to use, an not that icon's visual presence.
children: ({indeterminate, indeterminateIcon, children}) => (indeterminate ? indeterminateIcon : children) // This controls which icon to use, and not that icon's visual presence.
},

render: ({children, css, disabled, selected, ...rest}) => {
Expand Down
2 changes: 1 addition & 1 deletion Checkbox/Checkbox.module.less
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
line-height: 0;

.icon {
margin: 0; // Needed to apply here insetad of on `.checkbox` due to .icon.size precedence :(
margin: 0; // Needed to apply here instead of on `.checkbox` due to .icon.size precedence :(
border-radius: @sand-checkbox-border-radius;
position: relative;
text-align: center;
Expand Down
2 changes: 1 addition & 1 deletion ContextualMenuDecorator/ContextualMenuDecorator.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const ScrollingRepeater = ({className, ...rest}) => (
);

const ContextualMenuDecoratorBase = hoc(defaultConfig, (config, Wrapped) => {
// we might not need Skinnable at all here. If we want to skin the popup and it's defined as a
// we might not need Skinnable at all here. If we want to skin the popup, and it's defined as a
// private component in this module, we can wrap it with skinnable and style it as needed there.
const Component = Skinnable(
ContextualPopupDecorator(
Expand Down
4 changes: 2 additions & 2 deletions ContextualPopupDecorator/ContextualPopupDecorator.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ const Decorator = hoc(defaultConfig, (config, Wrapped) => {
snapshot.shouldSpotActivator = (
// isn't set
!current ||
// is on the activator and we want to re-spot it so a11y read out can occur
// is on the activator, and we want to re-spot it so a11y read out can occur
current === prevState.activator ||
// is within the popup
this.containerNode.contains(current)
Expand Down Expand Up @@ -358,7 +358,7 @@ const Decorator = hoc(defaultConfig, (config, Wrapped) => {
}

generateId = () => {
return Math.random().toString(36).substr(2, 8);
return Math.random().toString(36).substring(2, 10);
};

getContainerNodeWidth () {
Expand Down
2 changes: 1 addition & 1 deletion DatePicker/DatePicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ const DatePicker = Pure(
* @function
* @memberof sandstone/DatePicker
* @param {Date} date `Date` to convert
* @returns {String?} Converted date or `null` if `date` is invalid
* @returns {String|null} Converted date or `null` if `date` is invalid
*/
const dateToLocaleString = (date) => {
if (!date) {
Expand Down
2 changes: 1 addition & 1 deletion DayPicker/DayPicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const DayPickerBase = kind({
disabled: PropTypes.bool,

/**
* Called when an day is selected or unselected.
* Called when a day is selected or unselected.
*
* The event payload will be an object with the following members:
* * `selected` - An array of numbers representing the selected days, 0 indexed where Sunday
Expand Down
2 changes: 1 addition & 1 deletion DayPicker/DaySelectorDecorator.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ const DaySelectorDecorator = hoc((config, Wrapped) => {
locale: PropTypes.string,

/**
* Called when an day is selected or unselected.
* Called when a day is selected or unselected.
*
* The event payload will be an object with the following members:
* * `selected` - An array of numbers representing the selected days, 0 indexed
Expand Down
2 changes: 1 addition & 1 deletion DayPicker/tests/DayPicker-specs.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('DayPicker', () => {
// We need to change the locale to firstDayOfWeek !== 0.
// If firstDayOfWeek === 0, the number type check conditional statement
// is skipped due to the fast execution path of localizeSelected(), which
// reduces code coverage..
// reduces code coverage.
ilib.setLocale('es-ES');

render(<DayPicker locale="es-ES" selected={1} />);
Expand Down
Loading

0 comments on commit a788ad0

Please sign in to comment.