-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-6188: Added FloatingPopup prototype #1557
base: develop
Are you sure you want to change the base?
Conversation
- added floating popup component prototype - added floating popup default sampler Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1557 +/- ##
===========================================
+ Coverage 81.24% 81.27% +0.03%
===========================================
Files 141 142 +1
Lines 6499 6531 +32
Branches 1921 1928 +7
===========================================
+ Hits 5280 5308 +28
- Misses 932 936 +4
Partials 287 287 ☔ View full report in Codecov by Sentry. |
- added unit tests - cleaned up floating popup Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
I have some questions about the props and component naming.
|
- Changed component name to clearly - Added rtl prop and implemented rtl position Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
- Modified property name - Modified so that the location changes unconditionally depending on the direction - Fixed lint warning Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
|
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
LGTM. We don't have a fixed requirement yet, so I will keep this as a draft PR. |
Checklist
Issue Resolved / Feature Added
There is a requirement for a floating popup capable of free positioning.
This should also be able to receive content such as images and text.
This is a prototype implementation of the requirements.
Resolution
The component provides a container so that the app can pass contents inside the popup.
The component allows you to specify the desired position.
In the default sampler, we guide you on how to use it when passing images and text in the sampler.
Additional Considerations
Coordinate conversion may be required as the screen changes.
RTL may be required.
may need to trigger click events on components that are not hidden by the container.
Links
WRQ-6188
Comments
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)