Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-6189: Add PageViews component #1558

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

juwonjeong
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Add PageViews component which controls showing pages with indicators and steps.

Resolution

Move the WizardPanelsRouter function from WizardPanels/WizardPanels.js to WizardPanels/utils.js file to use in the PageViews component.
Implement PageViews component view.

Additional Considerations

Links

WRQ-6189

Comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (1349503) 81.24% compared to head (a4e7462) 80.80%.
Report is 9 commits behind head on develop.

Files Patch % Lines
PageViews/PageViews.js 0.00% 20 Missing and 8 partials ⚠️
PageViews/Page.js 0.00% 5 Missing and 1 partial ⚠️
PageViews/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1558      +/-   ##
===========================================
- Coverage    81.24%   80.80%   -0.44%     
===========================================
  Files          141      145       +4     
  Lines         6499     6534      +35     
  Branches      1921     1932      +11     
===========================================
  Hits          5280     5280              
- Misses         932      958      +26     
- Partials       287      296       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SkylerBaek SkylerBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We don't have specific requirements as of now, so let's keep this as-is until we'll get one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants