-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-19494: css-loader v7 migration #1619
Open
hong6316
wants to merge
12
commits into
develop
Choose a base branch
from
feature/WRQ-19494
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/enact_v5 #1619 +/- ##
====================================================
- Coverage 81.55% 79.21% -2.34%
====================================================
Files 148 148
Lines 6673 6673
Branches 1986 1986
====================================================
- Hits 5442 5286 -156
- Misses 938 1064 +126
- Partials 293 323 +30 ☔ View full report in Codecov by Sentry. |
* updated storybook to version 8 * Update samples/sampler/.storybook/manager.js * Update samples/sampler/.qa-storybook/manager.js * updated storybook to version 8 * fix for travis * merged with enact_v5 * code review fixes * removed changelog * code review fix * eslint fixes * eslint fixes * removed unneeded storybook ui properties * updated storybook to 8.1.6 * changed storybook-utils branch to enact_v5 * removed storybook docs configuration removed docs information in About story
* testing custom html head * custom favicon * added custom site icon for qa-sampler * Apply suggestions from code review * removed manager-head
* Fix Marquee to not override marqueeDirection * Fix Marquee to not override marqueeDirection 2 * modify travis.yml to verify * remove null * modify travis.yml to verify 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
css-loader v7 migration
https://github.com/webpack-contrib/css-loader/releases/tag/v7.0.0
Resolution
Change import style
Additional Considerations
Links
WRQ-19494
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)