Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-19494: css-loader v7 migration #1619

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented May 24, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

css-loader v7 migration
https://github.com/webpack-contrib/css-loader/releases/tag/v7.0.0

Resolution

Change import style

// Before
import style from "./style.css";

//After
import * as style from "./style.css";

Additional Considerations

  • Those changes should be descripted on migration guide, if decided to merge.
  • Those changes should be synced with tools including css-loader v7(cli, storybook-utils)

Links

WRQ-19494

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (67b330e) to head (64dfec9).

Current head 64dfec9 differs from pull request most recent head d2af02d

Please upload reports for the commit d2af02d to get more accurate results.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/enact_v5    #1619      +/-   ##
====================================================
- Coverage             81.55%   79.21%   -2.34%     
====================================================
  Files                   148      148              
  Lines                  6673     6673              
  Branches               1986     1986              
====================================================
- Hits                   5442     5286     -156     
- Misses                  938     1064     +126     
- Partials                293      323      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hong6316 hong6316 deleted the branch develop May 30, 2024 05:40
@hong6316 hong6316 closed this May 30, 2024
daniel-stoian-lgp and others added 4 commits June 17, 2024 09:51
* updated storybook to version 8

* Update samples/sampler/.storybook/manager.js

* Update samples/sampler/.qa-storybook/manager.js

* updated storybook to version 8

* fix for travis

* merged with enact_v5

* code review fixes

* removed changelog

* code review fix

* eslint fixes

* eslint fixes

* removed unneeded storybook ui properties

* updated storybook to 8.1.6

* changed storybook-utils branch to enact_v5

* removed storybook docs configuration
removed docs information in About story
@hong6316 hong6316 reopened this Jun 19, 2024
@hong6316 hong6316 changed the base branch from feature/node18 to feature/enact_v5 June 19, 2024 11:42
hong6316 and others added 7 commits June 19, 2024 20:42
* testing custom html head

* custom favicon

* added custom site icon for qa-sampler

* Apply suggestions from code review

* removed manager-head
* Fix Marquee to not override marqueeDirection

* Fix Marquee to not override marqueeDirection 2

* modify travis.yml to verify

* remove null

* modify travis.yml to verify 2
Base automatically changed from feature/enact_v5 to develop July 25, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants