-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-30519: Added accelerator to spectrum color picker #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andstone into feature/WRQ-30519-2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ColorPickerPOC #1659 +/- ##
==========================================================
- Coverage 78.75% 78.56% -0.19%
==========================================================
Files 154 154
Lines 6918 6934 +16
Branches 2027 2033 +6
==========================================================
Hits 5448 5448
- Misses 1141 1153 +12
- Partials 329 333 +4 ☔ View full report in Codecov by Sentry. |
stanca-pop-lgp
requested changes
Aug 8, 2024
stanca-pop-lgp
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Added accelerator to spectrum color picker
Resolution
Additional Considerations
Links
WRQ-30519
Comments
Enact-DCO-1.0-Signed-off-by: Paul Beldean paul.beldean@lgepartner.com