Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-30519: Added accelerator to spectrum color picker #1659

Merged
merged 10 commits into from
Aug 9, 2024

Conversation

paul-beldean-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Added accelerator to spectrum color picker

Resolution

Additional Considerations

Links

WRQ-30519

Comments

Enact-DCO-1.0-Signed-off-by: Paul Beldean paul.beldean@lgepartner.com

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (183ca1d) to head (6df0fc2).

Files Patch % Lines
ColorPickerPOC/SpectrumIndicator.js 0.00% 16 Missing and 8 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/ColorPickerPOC    #1659      +/-   ##
==========================================================
- Coverage                   78.75%   78.56%   -0.19%     
==========================================================
  Files                         154      154              
  Lines                        6918     6934      +16     
  Branches                     2027     2033       +6     
==========================================================
  Hits                         5448     5448              
- Misses                       1141     1153      +12     
- Partials                      329      333       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ColorPickerPOC/SpectrumIndicator.js Outdated Show resolved Hide resolved
ColorPickerPOC/SpectrumIndicator.js Outdated Show resolved Hide resolved
ColorPickerPOC/SpectrumIndicator.js Outdated Show resolved Hide resolved
ColorPickerPOC/SpectrumIndicator.js Outdated Show resolved Hide resolved
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanca-pop-lgp stanca-pop-lgp merged commit 719bbf7 into feature/ColorPickerPOC Aug 9, 2024
3 of 5 checks passed
@stanca-pop-lgp stanca-pop-lgp deleted the feature/WRQ-30519-2 branch August 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants