Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-30515: Added handler to display colors state in actions log when favorite color is removed #1660

Merged
merged 14 commits into from
Aug 9, 2024

Conversation

ion-andrusciac-lgp
Copy link
Contributor

@ion-andrusciac-lgp ion-andrusciac-lgp commented Aug 9, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

  • Added handler to display colors state in actions log when favorite color is removed
  • Added margin between Add button and list of favorite colors
  • Fixed spotlight navigation on the Add button and favorite colors

Resolution

Additional Considerations

Links

WRQ-30515

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (183ca1d) to head (346c287).
Report is 1 commits behind head on feature/ColorPickerPOC.

Files Patch % Lines
ColorPickerPOC/ColorPickerPOC.js 0.00% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/ColorPickerPOC    #1660      +/-   ##
==========================================================
- Coverage                   78.75%   78.38%   -0.37%     
==========================================================
  Files                         154      154              
  Lines                        6918     6950      +32     
  Branches                     2027     2041      +14     
==========================================================
  Hits                         5448     5448              
- Misses                       1141     1160      +19     
- Partials                      329      342      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ColorPickerPOC/ColorPickerPOC.js Outdated Show resolved Hide resolved
ColorPickerPOC/ColorPickerPOC.js Outdated Show resolved Hide resolved
ColorPickerPOC/ColorPickerPOC.js Outdated Show resolved Hide resolved
ColorPickerPOC/ColorPickerPOC.js Outdated Show resolved Hide resolved
ColorPickerPOC/ColorPickerPOC.module.less Outdated Show resolved Hide resolved
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanca-pop-lgp stanca-pop-lgp merged commit ed05176 into feature/ColorPickerPOC Aug 9, 2024
3 of 5 checks passed
@stanca-pop-lgp stanca-pop-lgp deleted the feature/WRQ-30515 branch August 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants