-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-32437: Fixed deletion of favorite colors for ColorPicker #1676
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ColorPickerPOC #1676 +/- ##
==========================================================
- Coverage 77.10% 77.05% -0.05%
==========================================================
Files 154 154
Lines 7066 7070 +4
Branches 2057 2058 +1
==========================================================
Hits 5448 5448
- Misses 1265 1268 +3
- Partials 353 354 +1 ☔ View full report in Codecov by Sentry. |
…andstone into feature/WRQ-32437
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check out my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
Issue Resolved / Feature Added
onPointerDown currently activates long press, which is ok for touch screens, but not for click.
Resolution
Removed mouse event handlers for favorite color buttons
Additional Considerations
Added an useEffect to update component state when the props for current color of favorite colors change.
Links
WRQ-32437
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)