Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-32437: Fixed deletion of favorite colors for ColorPicker #1676

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

daniel-stoian-lgp
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp commented Aug 22, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

onPointerDown currently activates long press, which is ok for touch screens, but not for click.

Resolution

Removed mouse event handlers for favorite color buttons

Additional Considerations

Added an useEffect to update component state when the props for current color of favorite colors change.

Links

WRQ-32437

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (900440a) to head (18cea23).
Report is 1 commits behind head on feature/ColorPickerPOC.

Files Patch % Lines
ColorPickerPOC/ColorPickerPOC.js 0.00% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/ColorPickerPOC    #1676      +/-   ##
==========================================================
- Coverage                   77.10%   77.05%   -0.05%     
==========================================================
  Files                         154      154              
  Lines                        7066     7070       +4     
  Branches                     2057     2058       +1     
==========================================================
  Hits                         5448     5448              
- Misses                       1265     1268       +3     
- Partials                      353      354       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out my comments.

ColorPickerPOC/ColorPickerPOC.js Outdated Show resolved Hide resolved
ColorPickerPOC/ColorPickerPOC.js Outdated Show resolved Hide resolved
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanca-pop-lgp stanca-pop-lgp merged commit 2abd154 into feature/ColorPickerPOC Aug 26, 2024
2 of 5 checks passed
@stanca-pop-lgp stanca-pop-lgp deleted the feature/WRQ-32437 branch August 26, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants