Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-171: Fix ui-tests to run with webdriverio v9 #1691

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

adrian-cocoara-lgp
Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp commented Sep 16, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Fixed ui-tests to run with webdriverio v9

Resolution

Additional Considerations

Starting with webdriverio v9:

Links

WRR-171

Comments

Enact-DCO-1.0-Signed-off-by: Adrian Cocoara adrian.cocoara@lgepartner.com

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (bde642e) to head (6c709d9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1691   +/-   ##
========================================
  Coverage    80.95%   80.95%           
========================================
  Files          148      148           
  Lines         6695     6695           
  Branches      2006     2006           
========================================
  Hits          5420     5420           
  Misses         969      969           
  Partials       306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hong6316
Copy link
Contributor

Please write a changelog about these changes.

package.json Outdated
@@ -62,6 +62,7 @@
"devDependencies": {
"@enact/docs-utils": "^0.4.10",
"@enact/ui-test-utils": "^1.0.9",
"eslint-config-enact-proxy": "^1.0.8"
"eslint-config-enact-proxy": "^1.0.8",
"tsx": "^4.19.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this module necessary? I cannot find any usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed when I first migrated to wdio9. Since it's not needed anymore, I removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants