-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRR-171: Fix ui-tests to run with webdriverio v9 #1691
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1691 +/- ##
========================================
Coverage 80.95% 80.95%
========================================
Files 148 148
Lines 6695 6695
Branches 2006 2006
========================================
Hits 5420 5420
Misses 969 969
Partials 306 306 ☔ View full report in Codecov by Sentry. |
Please write a changelog about these changes. |
package.json
Outdated
@@ -62,6 +62,7 @@ | |||
"devDependencies": { | |||
"@enact/docs-utils": "^0.4.10", | |||
"@enact/ui-test-utils": "^1.0.9", | |||
"eslint-config-enact-proxy": "^1.0.8" | |||
"eslint-config-enact-proxy": "^1.0.8", | |||
"tsx": "^4.19.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this module necessary? I cannot find any usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed when I first migrated to wdio9. Since it's not needed anymore, I removed it.
Checklist
Issue Resolved / Feature Added
Fixed ui-tests to run with webdriverio v9
Resolution
Additional Considerations
Starting with webdriverio v9:
isDisplayed
has been changed:https://webdriver.io/docs/api/element/isDisplayed/
(webdriverio): merge isDisplayed and isDisplayedWithinViewport webdriverio/webdriverio#11857
moveTo
has been changed to position the pointer on the center of an element. In previous version the pointer was placed on the top-left corner of an elementhttps://webdriver.io/docs/api/element/moveTo/
some components selectors and utily functions had to be modified. Running tests with wdio9 and chromedriver v120 introduced new bugs where the components are not selected correctly based on their id
Links
WRR-171
Comments
Enact-DCO-1.0-Signed-off-by: Adrian Cocoara adrian.cocoara@lgepartner.com