Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-789: Clean up default props in sandstone sampler #1731

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dongsuwon
Copy link
Contributor

Enact-DCO-1.0-Signed-off-by: Dongsu Won (dongsu.won@lgepartner.com)

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Some default props in sampler is being misused or omitted 'Default'.
So we need to default props in sampler.

Resolution

Fix default props in sampler as per the docs.

Additional Considerations

Links

WRR-789

Comments

* Update default props in sampler

Enact-DCO-1.0-Signed-off-by: Dongsu Won (dongsu.won@lgepartner.com)
Enact-DCO-1.0-Signed-off-by: Dongsu Won (dongsu.won@lgepartner.com)
Enact-DCO-1.0-Signed-off-by: Dongsu Won (dongsu.won@lgepartner.com)
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (a4d543d) to head (adeddaa).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1731   +/-   ##
========================================
  Coverage    81.55%   81.55%           
========================================
  Files          148      148           
  Lines         6673     6673           
  Branches      1985     1985           
========================================
  Hits          5442     5442           
  Misses         938      938           
  Partials       293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant