WRR-3979: Updated storybook to 8.4 #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1739 +/- ##
========================================
Coverage 80.87% 80.87%
========================================
Files 148 148
Lines 6676 6676
Branches 1989 1989
========================================
Hits 5399 5399
Misses 969 969
Partials 308 308 ☔ View full report in Codecov by Sentry. |
adrian-cocoara-lgp
approved these changes
Nov 14, 2024
MikyungKim
reviewed
Nov 27, 2024
# Conflicts: # samples/sampler/npm-shrinkwrap.json # samples/sampler/package.json
MikyungKim
reviewed
Dec 9, 2024
adrian-cocoara-lgp
pushed a commit
that referenced
this pull request
Dec 9, 2024
* added JS Docs * removed @module and indented code * fixed JS docs * fixed `too many doclets` error * fixed js docs warning * fixed JS docs * fixed js docs * added JD docs for SpectrumIndicator.js * refactored rgbStringToHex function and added `willReadFrequently: true` parameter in ColorPickerSpectrum for optimization * made ColorPicker main component public and ColorPickerGrid component props private * fixed qa sampler * removed forgotten console.log * removed transform as it conflicted with 5-way navigation * review fixes * modified example in JS docs * modified JS docs for ColorPicker example * JS docs fix * fixed JS docs * added default colors * fixed typo * fixed JS docs * changed slider names and adjusted tabLayout width * updated deprecated max-width value * moved max-width properties to target tabs class * corrected selector * fixed typo * added `type` and `disabled` props * changed type prop to public * added disabled style and behavior for each subcomponent of ColorPicker * added missing dependency * review fixes * added missing dependency * review fix * WRR-3979: Updated storybook to 8.4 (#1739) * updated storybook to 8.4 * updated to latest storybook * updated storybook-utils * review fix * dummy commit to fix cla license * revert dummy commit * removed spotlightDisabled from Dropdown as it is not recognized as a custom prop * undo spotlightDisabled removal - warning has different cause --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Storybook released 8.4 version which requires to migrate it in all enact repositories at the same time.
Resolution
Updated storybook to 8.4
Additional Considerations
Links
WRR-3979
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)