Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-8543: Fixed editable Scroller not to use static classname #1767

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

MikyungKim
Copy link
Contributor

@MikyungKim MikyungKim commented Dec 5, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Current editable Scroller uses static classname checking like ev.target.className.includes('Button').
This would not work when enactjs/cli#361 merged.

Resolution

Changed the code uses static classname to see role instead.

Additional Considerations

Links

WRR-8543

Comments

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (3e51a0b) to head (0d5fd3d).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1767   +/-   ##
========================================
  Coverage    80.88%   80.88%           
========================================
  Files          148      148           
  Lines         6671     6671           
  Branches      1988     1988           
========================================
  Hits          5396     5396           
  Misses         967      967           
  Partials       308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hong6316 hong6316 merged commit de22a0f into develop Dec 19, 2024
7 checks passed
@hong6316 hong6316 deleted the feature/WRR-8543-develop branch December 19, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants