Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-11059: update TabLayout storybook sample's icons #1773

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

SkylerBaek
Copy link
Member

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

As TabLayout sampler uses an icon list that is changing by font update, our screenshot tests are affected.

Resolution

I made a fixed list for TabLayout sampler so that a list of icons would not be affected by font changes.

Additional Considerations

Links

WRR-11059

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (b06e704) to head (4258a17).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1773   +/-   ##
========================================
  Coverage    80.87%   80.87%           
========================================
  Files          148      148           
  Lines         6676     6676           
  Branches      1989     1989           
========================================
  Hits          5399     5399           
  Misses         969      969           
  Partials       308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongsuwon
Copy link
Contributor

LGTM

@dongsuwon dongsuwon merged commit 5b666e4 into develop Dec 12, 2024
7 checks passed
@dongsuwon dongsuwon deleted the feature/WRR-11059 branch December 12, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants