WRR-12136: Converted sandstone/ThemeDecorator/AccessibilityDecorator to functional component #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/WRR-12136
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1774 +/- ##
===========================================
+ Coverage 80.87% 81.08% +0.21%
===========================================
Files 148 148
Lines 6676 6768 +92
Branches 1989 2037 +48
===========================================
+ Hits 5399 5488 +89
- Misses 969 975 +6
+ Partials 308 305 -3 ☔ View full report in Codecov by Sentry. |
…on from `useEffect`
juwonjeong
reviewed
Dec 20, 2024
Comment on lines
+47
to
+50
| if (prevTextSize.current !== textSize) { | ||
| resizeRegistry.current.notify({}); | ||
| prevTextSize.current = textSize; | ||
| } |
There was a problem hiding this comment.
I think we don't need to declare prevTextSize to check if textSize has changed.
There was a problem hiding this comment.
prevTextSize maintains a reference through re-renders and we're calling the notify function only if textSize is changed and differs from it's previous value; without prevTextSize, we can't track the previous value of the textSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Converted
AccessibilityDecoratorto a functional componentResolution
Additional Considerations
Links
WRR-12136
Comments
Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com