Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-13728: Migrated internal/SharedStateDecorator to functional component #1775

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

daniel-stoian-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

internal/SharedStateDecoratorwas a React class component

Resolution

Migrated internal/SharedStateDecorator to functional component

Additional Considerations

Links

WRR-10797

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (de22a0f) to head (d024f9c).

Files with missing lines Patch % Lines
...ernal/SharedStateDecorator/SharedStateDecorator.js 95.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1775   +/-   ##
========================================
  Coverage    80.90%   80.90%           
========================================
  Files          148      148           
  Lines         6678     6678           
  Branches      1989     1989           
========================================
  Hits          5403     5403           
  Misses         968      968           
  Partials       307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants