Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-12140: Convert sandstone/internal/DateTime/DateTimeDecorator to functional component #1777

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

alexandrumorariu
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

I converted sandstone/internal/DateTime/DateTimeDecorator to functional component.

Resolution

Additional Considerations

Links

WRR-12140

Comments

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (5e803d7) to head (be8d93b).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
internal/DateTime/DateTimeDecorator.js 88.23% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1777      +/-   ##
===========================================
+ Coverage    80.87%   80.99%   +0.12%     
===========================================
  Files          148      148              
  Lines         6676     6715      +39     
  Branches      1989     2005      +16     
===========================================
+ Hits          5399     5439      +40     
  Misses         969      969              
+ Partials       308      307       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants